Fatal error since >= 3.32.1: TypeError: TypedPropertiesDriver::shouldTypeHintInsideUnion

[nocive]

After the introduction of #1571 we experience a fatal error in a previously working codebase while serializing a doctrine entity object:

"exception": {
  "class": "TypeError",
  "message": "JMS\\Serializer\\Metadata\\Driver\\TypedPropertiesDriver::shouldTypeHintInsideUnion(): Argument #1 ($reflectionType) must be of type ReflectionNamedType, ReflectionIntersectionType given, called in vendor/jms/serializer/src/Metadata/Driver/TypedPropertiesDriver.php on line 184",
  "code": "0",
  "file": "vendor/jms/serializer/src/Metadata/Driver/TypedPropertiesDriver.php:192",
  "trace": [
    "vendor/jms/serializer/src/Metadata/Driver/TypedPropertiesDriver.php:184",
    "vendor/jms/serializer/src/Metadata/Driver/TypedPropertiesDriver.php:115",
    "vendor/jms/metadata/src/Driver/LazyLoadingDriver.php:38",
    "vendor/jms/metadata/src/MetadataFactory.php:111",
    "vendor/jms/serializer-bundle/Debug/TraceableMetadataFactory.php:42",
    "vendor/jms/serializer/src/GraphNavigator/SerializationGraphNavigator.php:234",
    "vendor/jms/serializer/src/JsonSerializationVisitor.php:101",
    "vendor/jms/serializer/src/GraphNavigator/SerializationGraphNavigator.php:172",
    "vendor/jms/serializer/src/JsonSerializationVisitor.php:101",
    "vendor/jms/serializer/src/GraphNavigator/SerializationGraphNavigator.php:172",
    "vendor/jms/serializer/src/Serializer.php:256",
    "vendor/jms/serializer/src/Serializer.php:163",
    ....

I saw that there are already other issues reported related to unions (such as #1566) but I didn't see any exhibiting the same symptoms so I'm reporting it just in case.

For now we're forced to pin 3.31.1 to work around the issue.

Thank you for the great work.

[scyzoryck]

Hi @nocive !

Could you share some example how to reproduce the issue? I guess we need some specific property type, but not sure how to reproduce it 😓

Best, Marcin.

[nocive]

@scyzoryck 👋

Might be a bit tricky to isolate it and figure out where it's coming from, but I'll try.

My best guess without diving deeper is that it could be caused by property declarations of the likes:

private (Collection&Selectable)|ArrayCollection $prop;

Would that make sense as a possible culprit from your pov?

[scyzoryck]

Thanks! Looks like a good candidate. We do not have such case in our test case. I'm wondering what should be the the type for deserialisation.

1. None - so it should be configured in other way
2. ArrayCollection

[nocive]

This is a doctrine entity ManyToMany relational property, hence the complex type.
It's a Collection&Selectable when retrieved from the db and an ArrayCollection when instantiated manually.

Probably doing nothing is the safer option but I think that preserving the previous behavior before the introduction of #1571 should be the way to go.