add JDK 13 community build

[SethTisue]

what, already? sure, why not. setting it up is easy, I know the drill now, and we have enough disk space on the workers.

early access builds are available from https://jdk.java.net/13/

[SethTisue]

JDK 13 is in final release, so it's time for this.

to conserve resources, we can get rid of the JDK 12 jobs.

[eed3si9n]

It might require sbt 1.3.1 that uses Scala 2.12.10.

[mr-git]

and https://jdk.java.net/14/ early builds are available too ;)

[SethTisue]

instructions for installing new OpenJDK versions on the behemoths: #942 (comment)

[SethTisue]

and https://jdk.java.net/14/ early builds are available too ;)

@mr-git I've made a separate ticket on that, though I don't plan to tackle it immediately: #984

[SethTisue]

JDKs installed on all 3 behemoths

job names/configurations updated

first runs in progress:

• https://scala-ci.typesafe.com/job/scala-2.12.x-jdk13-integrate-community-build/494/
• https://scala-ci.typesafe.com/job/scala-2.13.x-jdk13-integrate-community-build/398/

[SethTisue]

EXTRACTION FAILED (failed: blaze, doodle, fs2, genjavadoc, monix, paradox, sbt, sbt-io, sbt-librarymanagement, sbt-util, scala-async, scala-collection-compat, scala-continuations, scala-js, scala-partest, scala-swing, sconfig, sttp, tsec, zinc)

https://scala-ci.typesafe.com/job/scala-2.12.x-jdk13-integrate-community-build/494/artifact/logs/

I'll have to look at these one at a time.

[SethTisue]

repos that don't extract because they're on old sbt 1.x versions that don't work on JDK 13 (as @eed3si9n anticipated): blaze, doodle, fs2, genjavadoc, monix, paradox, sbt, sbt-*, scala-js, sconfig, sttp, tsec, zinc

Scala modules with hardcoded JDK version check needs updating: scala-async, scala-collection-compat, scala-continuations, scala-partest, scala-swing

I don't see any other classes of failure.

[SethTisue]

#986 should fix the modules. after that I'll think about what to do about the others

[TimMoore]

I just updated the wiki page (https://github.com/scala/community-builds/wiki) which had some dead links to the jdk12 builds.

[SethTisue]

I'll think about what to do about the others

a couple possible workarounds I've thought of:

• for the projects that need sbt 1.2, can we override the Scala version that sbt itself uses to be 2.12.10 instead of 2.12.7?
• maybe we could make sbt-1-2-version be 1.2.8 on most JDKs but 1.3.2 on JDK 13+. the projects that need sbt 1.2 will fail, but at least they should extract, allowing other projects to build

[SethTisue]

can we override the Scala version that sbt itself uses to be 2.12.10 instead of 2.12.7?

#991 tries this approach (-Dsbt.scala.version=2.12.10)

[SethTisue]

#991 is merged. all projects extract now, on both the 2.12.x and 2.13.x branches

let's see how the actual builds go:

• https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk13-integrate-community-build/521/
• https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-jdk13-integrate-community-build/413/ https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-jdk13-integrate-community-build/414/

[SethTisue]

2.13.x: SUCCEEDED: 138

• [jawn-0-11] [error] java.lang.IllegalArgumentException: Unsupported class file major version 57
• [expression-evaluator] [error] java.lang.IllegalArgumentException: Unsupported class file major version 57
• [log4s] [error] Unsupported class file major version 57
• [mockito-scala] [info] org.mockito.exceptions.base.MockitoException: Mockito cannot mock this class: class user.org.mockito.scalatest.IdiomaticMockitoTest$Foo. (and many similar)
• [sbt-io] [error] Error during tests: sbt.io.IOSpecification
• [scala-async] [error] java.lang.IllegalArgumentException: Unsupported class file major version 57
• [twitter-util:error] Unrecognized VM option 'AggressiveOpts'
• scala-js has compile errors from new overloads in Java stdlib

[SethTisue]

2.12.x: SUCCEEDED: 141 (https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk13-integrate-community-build/526/)

failures are about as above, plus:

• [utest] [error] java.lang.IllegalArgumentException: Unsupported class file major version 57
• [jawn-0-10] [error] Unsupported class file major version 57
  * [playframework] [error] Failed tests: play.mvc.HttpFormsTest
• [scala-partest] [error] Unsupported class file major version 57
• [curryhoward] java.lang.IllegalArgumentException: Unsupported class file major version 57
• [breeze] [error] Caused by: scala.tools.asm.tree.analysis.AnalyzerException: Error at instruction 3: Unsupported class file major version 57

[SethTisue]

declaring victory, according to our target ambition level

most of the 2.12 and 2.13 builds are green; the failures are don't look concerning, or are known issues in scala/bug

[SethTisue]

the 2.13.x-on-JDK-13 build keeps SIGSEGV'ing when running the scalacheck-shapeless tests — not every time, but very often

hoping a version upgrade would fix it, I did sudo apt-get install adoptopenjdk-13-hotspot which updated JDK 13 from a September 2019 build to 13.0.2+8-2 (done on all 3 behemoths)

but the first scalacheck-shapeless run on the new version still crashed. oh well

[SethTisue]

ha! scalacheck-shapeless segfaults even on JDK 14 (14-ea+32-1423) on macOS, even on 2.13.1 and outside dbuild. reported upstream: alexarchambault/scalacheck-shapeless#149