Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce JS library #557

Open
nulls opened this issue Nov 9, 2023 · 0 comments
Open

Reduce JS library #557

nulls opened this issue Nov 9, 2023 · 0 comments
Assignees
@nulls
Labels
enhancement New feature or request

Comments

@nulls
Copy link
Member

nulls commented Nov 9, 2023

We build save-common for JS, since we need plugin configurations on frontend. But ProcessBuilder and file system methods are not implemented for JS. Need to resolve these exception.

We can do it in two ways:

  • Extract an utils methods from save-common which don't have implementation on JS. Cons: save-common uses these utils methods in core and need to refactor it
  • Extract all configurations about plugins to a new module save-api which will have JS as a target. Cons: refactoring in save-cli and save-cloud
@nulls nulls added the enhancement New feature or request label Nov 9, 2023
@nulls nulls self-assigned this Nov 9, 2023
@nulls nulls mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nulls