bug: UnionValidator#setValidationEnabled does not make its members respect that

[Qjuh]

Is there an existing issue for this?

• I have searched the existing issues

Description of the bug

Found when disabling validation in @discordjs/builders on EmbedBuilder#setDescription() it would still throw a CombinedError with ExpectedValidationError in it.

Steps To Reproduce

import {s} from "@sapphire/shapeshift";

s.string
.lengthGreaterThanOrEqual(10)
.nullish
.setValidationEnabled(false).parse("test");

Expected behavior

It should not throw any Error.

Screenshots

No response

Additional context

No response

[kyranet]

Thing is, although the API is called setValidationEnabled, the getter method (getValidationEnabled()) is only called in tests, not a single time in the source code, and instead the library uses the getter below it (get shouldRunConstraints()):

shapeshift/src/validators/BaseValidator.ts

Lines 116 to 122 in afb87bf

	public getValidationEnabled() {
	return getValue(this.isValidationEnabled);
	}
	protected get shouldRunConstraints(): boolean {
	return getValue(this.isValidationEnabled) ?? getGlobalValidationEnabled();
	}

During validation, this.handle() is always called, even when get shouldRunConstraints() returns false:

shapeshift/src/validators/BaseValidator.ts

Lines 91 to 99 in afb87bf

	public parse<R extends T = T>(value: unknown): R {
	// If validation is disabled (at the validator or global level), we only run the `handle` method, which will do some basic checks
	// (like that the input is a string for a string validator)
	if (!this.shouldRunConstraints) {
	return this.handle(value).unwrap() as R;
	}
	return this.constraints.reduce((v, constraint) => constraint.run(v).unwrap(), this.handle(value).unwrap()) as R;
	}

In fact, if this.handle() wasn't called at all if it returned false, the effects would not only apply to the current validator, but also the children, since their parse() method wouldn't be called either.

We should change the name or the behaviour IMO. cc: @vladfrangu @favna

[favna]

I'd say we should change the behaviour.