Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does testing need an API key? #77

Open
tacman opened this issue Nov 21, 2024 · 2 comments
Open

does testing need an API key? #77

tacman opened this issue Nov 21, 2024 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Nov 21, 2024

I'm getting a lot of skipped tests, so I need to set an API key to run them? Does it make calls into Flickr, or are they mocked?

@samwilson
Copy link
Owner

It does need a key, because it makes actual calls to Flickr. It used to be possible to have a test account, but a few years ago they started deleting those.

We could mock the responses, but I wonder if it's worth it, considering most of the complexity here is in making sure that e.g. we have the correct parameter names.

@tacman
Copy link
Contributor Author

tacman commented Nov 21, 2024

I do think mocking the tests is the way to go, but it's such a pain. I'm trying to learn how to do that, since packages wrapping API calls are so valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants