Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add compatibility with any shell #6

Open
alextwothousand opened this issue May 9, 2021 · 5 comments
Open

Fix: Add compatibility with any shell #6

alextwothousand opened this issue May 9, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@alextwothousand
Copy link
Contributor

alextwothousand commented May 9, 2021

At the moment, we default to "sh" (for any non-windows OS) and "cmd" for Windows.
We should look into determining what shell the current user executed sampgo cli from, then using that.

@alextwothousand alextwothousand added the enhancement New feature or request label May 9, 2021
@ImOver00
Copy link
Contributor

ImOver00 commented May 9, 2021

I'd say we firstly would start with finding an ouput colouring library that is compatible with all shells (including Command Prompt, Old PS etc) because the current package we're using (Chalk) acts weird in those old terminals.

@alextwothousand
Copy link
Contributor Author

replace urfave/cli and chalk with pTerm.

@alextwothousand
Copy link
Contributor Author

Never mind, pTerm doesn't provide the functionality that urfave/cli does. But thats OK, we can just use pTerm instead of chalk-- it looks better anyway.

@ImOver00
Copy link
Contributor

ImOver00 commented May 9, 2021

We can use pTerm instead of Survey I think or otherwise we can use it for colouring and that's it.

@alextwothousand
Copy link
Contributor Author

We can use pTerm instead of Survey I think or otherwise we can use it for colouring and that's it.

The power of cross collaboration :)
You can give it a try in a separate branch and see if it works. IIRC pTerm would only be a replacement for chalk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants