Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for layout & spell selection on mobile/touch devices #17

Open
ashleybaldock opened this issue May 17, 2023 · 3 comments · May be fixed by #41
Open

fixes for layout & spell selection on mobile/touch devices #17

ashleybaldock opened this issue May 17, 2023 · 3 comments · May be fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@ashleybaldock
Copy link
Collaborator

ashleybaldock commented May 17, 2023

#41 will fix the majority of these issues.

Layout is mostly fine but could be tweaked to look better on a vertical format screen (main thing is to wrap the config bar)
Drag & drop works, but it's a bit fiddly (especially deleting spells)
Long-press to delete, or long-press to show menu (from which you could select a spell to replace it with or delete) might be nice

@salinecitrine
Copy link
Owner

I haven't tested the site at all on mobile, and to be honest I don't have a lot of experience with mobile, so I don't know the best way to approach this

@ashleybaldock
Copy link
Collaborator Author

It's not that bad really - hacked on it in browser dev tools for 5mins and got it looking ok by changing some flex attributes and adding a couple divs (needs media queries etc. too). Low priority though :)
mobile-2
mobile-1

@ashleybaldock ashleybaldock self-assigned this May 18, 2023
@ashleybaldock ashleybaldock added the bug Something isn't working label May 18, 2023
@salinecitrine
Copy link
Owner

that looks much better!

@ashleybaldock ashleybaldock linked a pull request Jul 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants