Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formal releases for the rule #9

Closed
plaird opened this issue Dec 19, 2019 · 1 comment
Closed

Formal releases for the rule #9

plaird opened this issue Dec 19, 2019 · 1 comment

Comments

@plaird
Copy link
Contributor

plaird commented Dec 19, 2019 •
edited
Loading

Right now we just suggest users copy the tools/springboot directory into their workspace (vendoring). Since it is small and self contained seems like good advice.

But there are other options. Especially with the the addition of the buildstamp work, we should invest some time into it. It would also be nice to have actual releases of the rule (e.g. 1.0.0), which may need to correspond to Bazel releases or Federation releases.

Consider especially this best practice, which is to zip up the current state of the repo as a .zip file:
https://docs.bazel.build/versions/master/external.html#repository-rules
@plaird plaird removed the question label Mar 25, 2020
@plaird
Copy link
Contributor Author

plaird commented Dec 11, 2020

We started doing this already. Using the Bazel standard layout for external rules is the next big step, and is tracked as issue #30

@plaird plaird closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plaird