Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct build JDK details when writing the Spring Boot MANIFEST.MF file #6

Open
plaird opened this issue Dec 17, 2019 · 1 comment

Comments

@plaird
Copy link
Contributor

plaird commented Dec 17, 2019

See write_manifest.sh. It helpfully inscribes the version of the JDK that was used to build the code in the generated Spring Boot application. Unfortunately, the value that is being written today is incorrect in many cases.

https://github.com/salesforce/bazel-springboot-rule/blob/master/tools/springboot/write_manifest.sh#L28

We need to inject this information from the actual JDK used to build the source (the toolchain), not the JDK that is in path while the genrule executes.

@plaird plaird added the bug label Dec 20, 2019
@plaird
Copy link
Contributor Author

plaird commented Dec 11, 2020

This will be easy to fix once Java toolchains are implemented correctly in Bazel. They just finished implementation of it in master yesterday.

Java Toolchain resolution in Bazel

We will have to figure out how to use that feature with backwards compatibility in mind. Not all users will be on the latest Bazel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant