Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double tap to wake support. #58

Open
ApostolosB opened this issue Dec 23, 2019 · 13 comments
Open

Double tap to wake support. #58

ApostolosB opened this issue Dec 23, 2019 · 13 comments

Comments

@ApostolosB
Copy link

...and lift to wake. On the stock rom you can have both of those features. The situation in AOSP is unclear to me. Hence i opened a enhancement request in the sony bugtracker.

Issue:
sonyxperiadev/bug_tracker#511

No replies yet but in case it can't be supported we can close this.

@rinigus rinigus changed the title Double tap to wakle support. Double tap to wake support. Dec 23, 2019
@MartinX3
Copy link

MartinX3 commented Dec 23, 2019

As far as I know it was connected to battery drain on the LED displays and the XZ3 doesn't support it on 4.9 because of a drain bug in the hardware driver which got maybe fixed in 4.14.
(Feature to lift the device and activate the display)
But maybe my memories are wrong.

@ApostolosB
Copy link
Author

As far as I know it was connected to battery drain on the LED displays and the XZ3 doesn't support it on 4.9 because of a drain bug in the hardware driver which got maybe fixed in 4.14.

Those on stock or on aosp??? Because i assume Sony wouldn't release them on stock if it drained the battery.

@MartinX3
Copy link

SODP is independent from the stock firmware.
The hardware drivers are developed by SODP sony employees without contact to the stock team.
They focus on 100% AOSP compatibility without any stock DRM.

@pagism
Copy link

pagism commented Dec 23, 2019

all these features I remember worked fine on sony's stock rom, battery drain on XZ3 was minimal overnight (<5%). on display notifications are also turned off after a short period, so the display was going blank.
Unless xz3 has different type of sensors, double tap should apply on all tama devices(?)

@rinigus
Copy link
Contributor

rinigus commented Dec 23, 2019

So, that tells that it is possible from hardware sine on XZ3. However, AOSP drivers could be different from stock. As for double tap on XZ2/XZ2c, I don't know if they have the same events as XZ3 - screens are different.

So, let's check it out if its possible on AOSP first, then move to SFOS. Note that SFOS has wakeup functionality based on proximity sensor. That can be tested using mcetools, grep TJC for instructions.

@pagism
Copy link

pagism commented Dec 23, 2019

TJC instructions for double tap, I need to finish battery tests first tho.

@rinigus
Copy link
Contributor

rinigus commented Dec 23, 2019

Please finish battery tests first. These double tap instructions are going to prevent suspending which will be killing battery (brief scan of instructions).

@ApostolosB
Copy link
Author

Someone answered in the sony bugtracker and afai understand is a matter of a config option to have it enabled. However it doesn't guarantee it will work hassle free.

I'd like to know how Sony made it work.

@rinigus
Copy link
Contributor

rinigus commented Dec 24, 2019

Nice, we have instructions. I am in the middle of one other work right now, will be able to do it probably in the beginning of January. Ping me if I forget about it

@rinigus
Copy link
Contributor

rinigus commented May 20, 2020

Pickup gesture is supported now, see README, section tips. Double tap will have to wait.

@ApostolosB
Copy link
Author

@rinigus in case the pickup to wake support is something the official devices can use ping jolla people. They might want to add it to the devices.

@rinigus
Copy link
Contributor

rinigus commented May 21, 2020

I don't know if that is supported by Xperia 10. But the work on it is documented in IRC logs and I had help from Jolla's devs. So, they know already

@bam80
Copy link

bam80 commented Nov 2, 2021

Could you guys help me to find out where this feature is implemented in SailfishOS for PhinePhone?
I see there is mcetool which might do the trick, but can't find it's source code to check..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants