Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor PhpAttribute #1

Open
sagittaracc opened this issue Apr 17, 2024 · 0 comments
Open

refactor PhpAttribute #1

sagittaracc opened this issue Apr 17, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sagittaracc
Copy link
Owner

Need to refactor the PhpAttribute class - https://github.com/sagittaracc/decorator/blob/main/src/PhpAttribute.php

It has getMethod and getProperty methods which is not quite obvious

Need to create a new class so called AttributeMapper which has both of those methods

Use case would be like this

AttributeMapper::getMethodByAttribute($object, $attribute); // callable
AttributeMapper::getPropertyByAttribute($object, $attribute); // property name
@sagittaracc sagittaracc added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sagittaracc