Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types-kit): sync SafeMultisigTransactionResponse types with API #1117

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fix(types-kit): sync SafeMultisigTransactionResponse types with API #1117

merged 4 commits into from
Jan 31, 2025

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 31, 2025

What it solves

Resolves #1008

How this PR fixes it

Adds that some properties could be returned as null

@dasanra dasanra requested a review from DaniSomoza January 31, 2025 09:37
@coveralls
Copy link

coveralls commented Jan 31, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13073749706

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.773%
Totals Coverage Status
Change from base Build 13073743584: 0.0%
Covered Lines: 800
Relevant Lines: 992
💛 - Coveralls

@dasanra dasanra linked an issue Jan 31, 2025 that may be closed by this pull request
SafeMultisigTransactionResponse type is incorrect #1008
Closed
@dasanra dasanra merged commit 90f716c into development Jan 31, 2025
22 checks passed
@dasanra dasanra deleted the improve-api-kit-types branch January 31, 2025 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DaniSomoza DaniSomoza DaniSomoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SafeMultisigTransactionResponse type is incorrect
3 participants
@dasanra @coveralls @DaniSomoza