Add Ethena

[Mostafatalaat770]

Entry type

• New addition

App info

URL:
https://app.ethena.fi

Manifest.json URL:
https://app.ethena.fi/manifest.json

Name:
Ethena

Description:
Ethena is a synthetic dollar protocol built on Ethereum that provides a crypto-native solution for money not reliant on traditional banking system infrastructure, alongside a globally accessible dollar denominated rewards instrument - the 'Internet Bond'.

Icon (PNG, 180x180):
https://app.ethena.fi/shared/ethena.png
It's minified via https://tinypng.com: no

Homepage: https://ethena.fi
Twitter: https://twitter.com/ethena_labs
GitHub: https://github.com/ethena-labs
Discord: https://discord.gg/ethena

App supports batching multiple transactions via Safe: no

Supported networks

- Mainnet

Revision checks

• Used smart contracts were audited.
• You have implemented the app using the Safe Apps SDK
• Your Safe App includes a manifest.json file at the root with the required data
• The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
• The app auto-connects to the Safe as a wallet
• It doesn't try to connect to the browser wallet (e.g. MetaMask)
• You are able to trigger and execute one transaction with a Safe.
• RPC requests are optimized (not triggering many requests in a very short time period).

Audit document

https://ethena-labs.gitbook.io/ethena-labs/resources/audits

Code for review

Team information

Company: Ethena Labs

Official website: https://ethena.fi

Point of contact: https://ethena-labs.gitbook.io/ethena-labs/resources/terms-of-service

Email/Telegram: https://t.me/ethena_labs

[kirkkonen]

This submission is approved by the wallet product team.

[iamacook]

@Mostafatalaat770, to proceed with the review of the Safe App, please add me to the code repository so we can review the code.

[Mostafatalaat770]

sure!, I've added you to the repo:
https://github.com/ethena-labs/ethena

[iamacook]

Despite the lack of test coverage, I did not encounter any critical issues with the submission. I’m happy to pass it on to QA for further review. cc @francovenica

[francovenica]

1 - Rejecting the terms of service does nothing.
I see that in your standalone app it disconnects the wallet. Can you do the same here?

[francovenica]

2 - Accepting the terms of service is not stored anywhere, so I have to accept it everytime I start the app

3 - Clicking on the address on the top right brings out a modal with the chance to copy the address or disconnect from it. Both options won't work (the address is not copied, I cannot disconnect)

[francovenica]

4 - The Delegate feature is incompatible with the safe, because it asks to switch to other networks, something that a safe cannot do, even if it was deployed in those networks. That switching is not possible here

[francovenica]

5 - I tried a swap. It worked fine, but the app does not "notice" that the tx is done, so you stay waiting here.
The same happens with "Staking"
The tx is successful, so no funds are getting stuck or anything. Still is a compatibility issue the app has with the safe not closing the modal once the tx is done

[PooyaRaki]

@Mostafatalaat770 We are awaiting your response to proceed with the process.

[PooyaRaki]

@Mostafatalaat770 I’m closing this issue for now due to inactivity. Please feel free to reopen it with any updates.

[deHB6]

2 - Accepting the terms of service is not stored anywhere, so I have to accept it everytime I start the app

3 - Clicking on the address on the top right brings out a modal with the chance to copy the address or disconnect from it. Both options won't work (the address is not copied, I cannot disconnect)

First item here is addressed

On the second item, Copying to clipboard seems an issue with clipboard API and iframes, we've logged this issue in the rainbowkit repo rainbow-me/rainbowkit#2294

[deHB6]

All items here have been addressed, do you mind re-opening and having another look? @PooyaRaki @francovenica @iamacook

[PooyaRaki]

@deHB6 Thanks for the update. We'll review the changes and will get back to you.

[francovenica]

Issues 1, 2 and 4 where fixed. Issue 3 is not a blocker so we can wait on ranibowkit to fix it.

I still get the issue 5, when I try to approve and swap a token. The interface still waits there indefinitely even when the tx has already executed. Again, there is no problems whe the approval or the swap themselves, those work fine, but still might give the user the wrong impression.
If it works fine on your side let me know and we can see why is failing on mine.
In any case, I'll discuss with my team if this is a blocker or not.

[Mostafatalaat770]

Thanks for the feedback!

For 5, we noticed a behavior where when someone switches the signer it also switches the connected safe wallet in the dapp to the new signer, do you have this behavior? Also can you attach a video or send the wallet address?

[francovenica]

Hi there.

I'll show you a gif of a tx to approve the use of USDT and the tx itself.
One thing that my team ask me to suggest is that you should check if the app is waiting for the TransactionHash or the SafeTxHash, because it should be waiting for the latter.

The tx:
https://app.safe.global/transactions/tx?safe=eth:0x8675B754342754A30A2AeF474D114d8460bca19b&id=multisig_0x8675B754342754A30A2AeF474D114d8460bca19b_0xf40ee8c841cec0e5f5d296a31eafc59599952ce488a3d188cab1af95ceb4e120

(if the gif is kinda bumpy is because I edited it to be shorter)