How should we implement the target contract to make it possible to batch-create streams without reverting the entire tx if a subset of the streams fail to be created?

[PaulRBerg]

We will write PRBProxy-powered target contracts to batch-create streams.

The question is: how to implement the batch-create streaming function without reverting the entire tx if a subset of the streams fail to be created?

[PaulRBerg]

I think the solution for this is try/catch.

[PaulRBerg]

@andreivladbrg can you post an update here? I recall that we've talked about this at one point and you ended up reverting the whole tx even if just one stream failed.

[andreivladbrg]

Initially I implemented the create multiple functions with a try/catch statement but I realised that this is wrong because it will lead us into a bug. In the current version of the functions we are transferring a totalAmount(an amount for all the streams) in the periphery contract and if one of the stream creation would fail, money would be lost because the function would not revert.

[PaulRBerg]

Well, it doesn't necessarily lead to a bug. It just leads to a situation that would have to be handled explicitly to transfer the funds back to the user.

However, in the context of PRBProxy, this wouldn't even lead to a problem, because any funds in the PRBProxy can always be transferred back to the user (with a bespoke target contract).

Whatever the case - I am happy to keep the behavior as you implemented it, @andreivladbrg (revert even if just one stream fails).

[PaulRBerg]

Locking as we have decided to revert the entire transaction even if just one stream creation tx fails.