-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powerful command line options for deployment script #752
Powerful command line options for deployment script #752
Conversation
690f1c0
to
b601577
Compare
b601577
to
98a74dd
Compare
79aa953
to
5b2eb75
Compare
98a74dd
to
d2472aa
Compare
8827002
to
0b6d4ee
Compare
d2472aa
to
29c2f85
Compare
if ~ ./shell/deploy-multi-chain.sh --print avalanche
Compiling the contracts...
Deployment on avalanche started...
+ Simulating on forked network
+ Printing command without action
forge script script/DeployCore3.s.sol --rpc-url https://avalanche-mainnet.infura.io/v3/68967a55fb91488684a9c1000f321d7f --sig 'run(address,address,uint256)' 0x6666cA940D2f4B65883b454b7Bc7EEB039f64fa3 0x66F5431B0765D984f82A4fc4551b2c9ccF7eAC9C 300 -vvv
End of it without ~ ./shell/deploy-multi-chain.sh avalanche
Compiling the contracts...
Deployment on avalanche started...
+ Simulating on forked network
No files changed, compilation skipped
Script ran successfully.
== Return ==
nftDescriptor: contract SablierV2NFTDescriptor 0xaC7A8d8e1131432393009a16eF0965A66C64E570
lockupDynamic: contract SablierV2LockupDynamic 0xCB13Ac0e8DF85ceE89DcdBF3F30547497722F27E
lockupLinear: contract SablierV2LockupLinear 0x604b3daacBa6a53eF61afeAeC5fC289E7E1C0764 |
@andreivladbrg I think this is quite a powerful and flexible script we have developed here. Let me know if you have new suggestions. |
cec201f
to
748131a
Compare
I've reviewed the script, and I'm impressed - great work @smol-ninja. I've only given it a cursory review, but it generally looks good to me. We can test it some more when we get to deploy V2.2 Side note: as suggested here, it might be worthwhile to turn this script into an internal Rust-based CLI utility. It has become complex enough for a Bash script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* build: add deploy multi chains script build: remove etherscan api keys in foundry.toml feat: add deploy core 3 scripts chore: improve .env.example file * build: add arbitrum sepolia chore: git ignore deployments dir * chore: update wording in scripts chore: remove forge fmt comment * refactor: separate base env from deployment env chore: improve multi-chain deployment script refactor: rename env var MAX_SEGMENT_COUNT * refactor: rename multi-chain script * chore: fix arbitrum config key * fix: use array to create deployment command * chore: create an array for deployment command * Powerful command line options for deployment script (#752) * build: add script to generate deployment command * feat: new command-line options for deploy-multi-chain command * chore: continue for warnings and throw for errors * perf: polish deployment script --------- Co-authored-by: Paul Razvan Berg <[email protected]> * refactor: hard code admin addresses --------- Co-authored-by: andreivladbrg <[email protected]> Co-authored-by: smol-ninja <[email protected]>
Resolves #751
Usage
Description
Note: Enters interactive mode if .env.deployment not found