Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run slither job periodically #719

Closed
andreivladbrg opened this issue Oct 26, 2023 · 2 comments
Closed

Run slither job periodically #719

andreivladbrg opened this issue Oct 26, 2023 · 2 comments
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@andreivladbrg
Copy link
Member

In the latest PR, we added the slither job to our CI.

https://github.com/sablier-labs/v2-core/blob/3883dc3f3b2d33c7519292404e4942969a4dd2f2/.github/workflows/ci.yml#L289-L317

After it ran twice, I realized it might take significantly longer compared to other jobs:
https://github.com/sablier-labs/v2-core/actions/runs/6654049027

I believe it would be more efficient to move the slither job to a separate workflow, similar to the deep job that runs weekly. We could schedule the slither job to run daily or weekly.
@PaulRBerg
Copy link
Member

Agree

@andreivladbrg andreivladbrg mentioned this issue Nov 8, 2023
Merged
@PaulRBerg PaulRBerg added type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. priority: 3 Nice-to-have. Willing to ship without this. effort: medium Default level of effort. and removed enhancement labels Jan 1, 2024
@PaulRBerg
Copy link
Member

Closing as this has been implemented in #726.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 3 Nice-to-have. Willing to ship without this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @andreivladbrg