From 57df8f02f8d9f2d0e0b234fa6e0b01d2caaea4da Mon Sep 17 00:00:00 2001 From: andreivladbrg Date: Mon, 20 Nov 2023 15:45:29 +0200 Subject: [PATCH] chore: improve explanatory comment in dynamic contract --- src/SablierV2LockupDynamic.sol | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/SablierV2LockupDynamic.sol b/src/SablierV2LockupDynamic.sol index df48a3309..389e80189 100644 --- a/src/SablierV2LockupDynamic.sol +++ b/src/SablierV2LockupDynamic.sol @@ -515,7 +515,9 @@ contract SablierV2LockupDynamic is // Log the cancellation. emit ISablierV2Lockup.CancelLockupStream(streamId, sender, recipient, asset, senderAmount, recipientAmount); - // Emits an ERC-4906 event to trigger an update of the NFT metadata. We are + // Emits an ERC-4906 event to trigger an update of the NFT metadata. The `updateMetadata` modifier isn't used + // here to avoid DOS attacks by malicious recipient contracts, which could force excessive gas costs on the + // sender. emit MetadataUpdate({ _tokenId: streamId }); // Interactions: if the recipient is a contract, try to invoke the cancel hook on the recipient without