Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RES functionalities #5

Open
3v1n0 opened this issue Jul 4, 2023 · 15 comments
Open

Include RES functionalities #5

3v1n0 opened this issue Jul 4, 2023 · 15 comments

Comments

@3v1n0
Copy link

3v1n0 commented Jul 4, 2023

Hi, it would be nice to optionally support RES functionalities.

I suppose the RES code should be kind of embedded in mlmym or initially we could may be patch it to support the mlmym uris and code references instead as a first step?

@rystaf
Copy link
Owner

rystaf commented Jul 5, 2023

Are there any specific RES functions you'd like to see added?

@3v1n0
Copy link
Author

3v1n0 commented Jul 5, 2023

Mostly keybindings support, but it would be cool if the generated code would be close enough so that RES could work on top of mlmym as it is (but I suppose that's nearly impossible).

However things like multi-user support and ability to highlight comments by age is something that was really cool.

@ghost
Copy link

ghost commented Jul 5, 2023

Would be nice to have the "Hide all child comments" function from RES 😄 Probably my most used function

And then it would be nice to have a quick-switch to dark-mode, so you don't have to navigate to the Settings -> Dark Mode. Or even better, since this is self-hostable, an option to make your own instance "dark mode by default" instead of light mode by default.

@swedneck
Copy link

swedneck commented Jul 5, 2023

A feature from RES i'm missing is the ability to scale images by clicking and dragging on them, very handy.

@RandomUsername404
Copy link

RandomUsername404 commented Jul 5, 2023

There's a couple of RES features I'm missing (along with the one mentioned by swedneck above):

  1. A quick night mode toggle.
    toggle
  2. A Markdown editor for when I have a brainfart.
    markdown editor

Speaking of Markdown, I noticed the spoiler tag wasn't supported. See here.

That being said, thanks a lot for what you've done, Ryan. This project of yours is fantastic!


Edit: The spoiler tag issue seems to be fixed! Thanks!

@aghpub
Copy link

aghpub commented Jul 6, 2023

Are there any specific RES functions you'd like to see added?

Never ending Reddit Lemmy (endless scrolling) would be very nice to have.

Anyway, thank you for making this "theme" available at all. I hope this project gains popularity and some moire contributors.

@jivandabeast
Copy link

+1 on the infinite scrolling -- easily one of the key features of RES for me

@wi-ry
Copy link

wi-ry commented Jul 7, 2023

I'm hoping for expand all images!

@wi-ry
Copy link

wi-ry commented Jul 7, 2023

Are there any specific RES functions you'd like to see added?

Never ending Reddit Lemmy (endless scrolling) would be very nice to have.

Anyway, thank you for making this "theme" available at all. I hope this project gains popularity and some moire contributors.

Quick-and-dirty Greasemonkey script - https://greasyfork.org/en/scripts/470312-endless-mlmym

// ==UserScript==
// @name     Endless mlmym
// @include  https://mlmym.org/*
// @require  http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js
// @require  https://gist.github.com/raw/2625891/waitForKeyElements.js
// @grant    GM_addStyle
// ==/UserScript==
/*- The @grant directive is needed to work around a design change
    introduced in GM 1.0.   It restores the sandbox.
*/

function clickMoreBtnWhenItAppears (jNode) {
    var clickEvent  = document.createEvent ('MouseEvents');
    clickEvent.initEvent ('click', true, true);
    jNode[0].dispatchEvent (clickEvent);
}

//-- Value match is case-sensitive
waitForKeyElements (
    //"#loadmore input[type='submit'][value*='Click Me Now']",
    "input[type='submit'][value*='load more']",
    clickMoreBtnWhenItAppears
);

@vmavromatis
Copy link

vmavromatis commented Jul 7, 2023

UPDATE: I have now posted the script on github https://github.com/vmavromatis/Lemmy-keyboard-navigation Still only works on just lemmy though (not mlmym yet). I will try to make it work with that too.

@jadedgnome
Copy link

the dashboard

@chdhr-harshal
Copy link

I would love to have an easy way to access the communities that I am subscribed to. On reddit, there was a "My subreddits" menu in the top bar. So that would be a nifty menu in addition to a customizable top bar similar to RES extension.

Screen Shot 2023-07-14 at 8 30 51 PM

@RarePossum
Copy link

Personally, I'd like user tags and comment filters if possible.

@Nicknakin
Copy link

Navigating comments by selecting one, moving around with j/k and collapsing with enter would be amazing! Almost as good would be the resizable images with the image expando feature.

@vmavromatis
Copy link

vmavromatis commented Aug 29, 2023

The keyboard navigation userscript for mlmym is finally up! 🎉 🎉 🎉

Just make sure you have tampermonkey or greasemonkey or whatever installed, then grab script from here.

If you face any issues just hop to here https://github.com/vmavromatis/Lemmy-keyboard-navigation/issues

All credits go to InfinibyteF4 for his amazing work.

@rystaf you may want to consider to add these functionalities into the main code, by all means feel free. I know keyboard navigation was one of the top features of RES and I see you are incorporating some RES functionalities in your site, which is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests