Refactor the Warning type
#278
Open
+45
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dude f*** the MSRV. I can't use |
|
Thought about it for a second. While the last commit would be useful, the |
rustaceanrob
force-pushed
the
warning-1-22
branch
from
33e5c8a to
bb934c3
Compare
nyonson
reviewed
Jan 24, 2025
| @@ -1641,7 +1641,7 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "kyoto-cbf" | |||
| version = "0.7.0" | |||
| version = "0.8.0" | |||
nyonson
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277
Cleaning up the
Warningtype here to resolve a typo, refactor to clearer names, and add additional context to warnings so the developer might act on them. Also adding some additional context to aHeaderPersistenceError.Each refactor is broken down commit by commit so it should be okay to review. Only context needed is in the
CannotLocateHistoryvariant, which throws if the user configures a checkpoint that is at a height lower than what is stored in the SQL database on start up. This prevents the user from going backwards if they have already synced before, which is a pretty soft requirement. For the first sync one can start from anywhere. @nyonson