fix: Sort completion items that skip await and iter() behind those that don't
#18988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jan 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…t don't I don't think my ranking is perfect, because it places them even behind snippet completions, but this is something.
ChayimFriedman2
force-pushed
the
iter-relevance
branch
from
bca00b1 to
8e0bc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think my ranking is perfect, because it places them even behind snippet completions, but this is something.
Fixes #18985.