Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some places coming out as being located on null island #2

Open
MoralCode opened this issue Sep 21, 2024 · 2 comments · May be fixed by #3
Open

Some places coming out as being located on null island #2

MoralCode opened this issue Sep 21, 2024 · 2 comments · May be fixed by #3

Comments

@MoralCode
Copy link

context: null island is a location in the ocean off the african coast where the lat/long is 0,0.

i just exported my saved places and about 4/6 of them are being set to null island.

I checked the source data and it seems like the place in the geojson where the coordinates are stored is indeed providing coordinates of 0,0, however, theres a google maps URL field that contains more plausible coordinates.

from the geoJSON:

 {
      "geometry": {
        "coordinates": [
          0,
          0
        ],
        "type": "Point"
      },
      "properties": {
        "date": "2024-05-28T18:42:08Z",
        "google_maps_url": "http://maps.google.com/?q=42.30039043516156,-71.12115081399679",
        "Comment": "No location information is available for this saved place"
      },
      "type": "Feature"
    },

Would it be helpful to include detection for these null coordinates and replacing them with the coordinates from the url?

@rudokemper
Copy link
Owner

I noticed that in my own GeoJSON too; seems like an artifact from Google's export code. And yes, that's a great suggestion to detect null coords and retrieve it from the URL instead! (If someone actually bookmarked null island, the coords from the URL would be the same anyway.)

Do you want to contribute that? Or I can handle it later, not at my computer this weekend.

@MoralCode
Copy link
Author

im a good way there already :P apparrently the URLs can contain addresses (typically happens when the address isnt a business, otherwise google would have grabbed the coordinates already).

So yeah ill probably use https://nominatim.openstreetmap.org to look up coords for the addresses I find too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants