Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in long call chains regressed in 6.2.0 #411

Open
CvX opened this issue Sep 25, 2023 · 1 comment
Open

Comments in long call chains regressed in 6.2.0 #411

CvX opened this issue Sep 25, 2023 · 1 comment

Comments

@CvX
Copy link

CvX commented Sep 25, 2023

formatting in 6.1.1:

    keys =
      ApiKey
        .where(hidden: false)
        .includes(:user, :api_key_scopes)
        # Sort revoked keys by revoked_at and active keys by created_at
        .order("revoked_at DESC NULLS FIRST, created_at DESC")
        .offset(offset)
        .limit(limit)

formatting in 6.2.0 (includes() is split into multiple lines, the comment is now next to the ), . on its own line)

    keys =
      ApiKey
        .where(hidden: false)
        .includes(
          :user,
          :api_key_scopes,
        )# Sort revoked keys by revoked_at and active keys by created_at
        .
        order("revoked_at DESC NULLS FIRST, created_at DESC")
        .offset(offset)
        .limit(limit)

See the failing Dependabot PR: discourse/discourse#23633 (that branch now also includes updated multiline lambda formatting)

@levibuzolic
Copy link

Have traced this back to this line of this change: b345765#diff-4a62a987e00853ea4da04a58594e31564bc9afc77a1cbdf95f95493784360659R2852-R2855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants