Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using redux-persist-migrate, the keys are not added #19

Open
deecewan opened this issue Dec 29, 2016 · 0 comments
Open

When using redux-persist-migrate, the keys are not added #19

deecewan opened this issue Dec 29, 2016 · 0 comments

Comments

@deecewan
Copy link

Hey,

I'm wanting to add a key using redux-persist-migrate to hold my migration status. It was not working, so I took a look through the code. The thing that seems to be causing it is https://github.com/rt2zz/redux-persist-immutable/blob/master/src/reconciler.js#L8

It is returning straight away if the key isn't present. However, further down in the same function, there is a test to see if the key is present. https://github.com/rt2zz/redux-persist-immutable/blob/master/src/reconciler.js#L18 which will never be fired, because the function has already returned if that is false.

Is there a reason we return early when rehydrating if the key doesn't exist? It doesn't seem like the intended functionality, because there is code that exists below that will set it on the store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant