Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classes matching .NET classes #143

Open
NN--- opened this issue Sep 8, 2021 · 2 comments
Open

Rename classes matching .NET classes #143

NN--- opened this issue Sep 8, 2021 · 2 comments

Comments

@NN---
Copy link
Member

NN--- commented Sep 8, 2021

There are few classes with the same name as .NET has:

  • CodeJam.HashCode - System.HashCode
  • CodeJam.Collections.CollectionExtensions - System.Collections.Generic.CollectionExtensions
  • CodeJam.Ranges.Range - System.Range
@NN---
Copy link
Member Author

NN--- commented Aug 29, 2023

@igor-tkachev @andrewvk What do you think?
I know it is a breaking change but it makes writing code a little bit harder.
Or we just leave it as it ?

@rameel
Copy link
Contributor

rameel commented Sep 2, 2023

CollectionExtensions does not conflict with System.Collections.Generic.CollectionExtensions, and is rarely used directly by name, except perhaps when creating a delegate (method group). Therefore, I don't see a reason to change its name.

HashCode, we can rename it to HashHelper or HashUtil as an example.
Range - I have no thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants