Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Node Parent casting of undefined #1443

Closed
1 task done
yimejky opened this issue Apr 9, 2024 · 2 comments
Closed
1 task done

[Bug]: Node Parent casting of undefined #1443

yimejky opened this issue Apr 9, 2024 · 2 comments

Comments

@yimejky
Copy link

yimejky commented Apr 9, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

2.0.0-alpha.12

Expected Behavior

The library shouldn't crash and spam the web and its performance.

Actual Behavior

We have an angular web, where we use Posthog monitoring, and the problematic part seems to be this lib. One of our forms starts to spam the console and the performance with an error after rendering.

image

I backtracked the code to

if ((n.parentNode as Element).tagName === 'TEXTAREA') {

where the casting pretends the node always has a parent, and it's connected to the DOM.

Steps to Reproduce

Unfortunately, I have no idea why is it happening. My suspect is race condition of too many updates or something like that. The problematic node simply doesn't have a parent at the time of execution.

@eoghanmurray
Copy link
Contributor

Is this fixed in #1445 ?

@yimejky
Copy link
Author

yimejky commented Apr 15, 2024

Is this fixed in #1445 ?

Probably yes. I will update our FE this week.

@yimejky yimejky closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants