Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSF address check #1286

Closed
funnelfiasco opened this issue Oct 11, 2024 · 2 comments · Fixed by #1306
Closed

Update FSF address check #1286

funnelfiasco opened this issue Oct 11, 2024 · 2 comments · Fixed by #1306

Comments

@funnelfiasco
Copy link

The FSF is remote as of 1 September, so the wrong address check should also check for the now-former address:

51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA

@danigm
Copy link
Member

danigm commented Oct 24, 2024

Right now we're just checking this regex for FSF wrong address:

fsf_wrong_address_regex = re.compile(br'(675\s+Mass\s+Ave|59\s+Temple\s+Place|02139)', re.IGNORECASE)

So if I understand correctly we should also add that line to the regex to be something like:

fsf_wrong_address_regex = re.compile(br'(675\s+Mass\s+Ave|59\s+Temple\s+Place|02139|51\s+Franklin\s+Street)', re.IGNORECASE)

@funnelfiasco
Copy link
Author

That seems reasonable to me.

danigm added a commit that referenced this issue Jan 7, 2025
The FSF is remote as of 1 September, so the wrong address check should also
check for the now-former address:

> 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA

Fix #1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants