Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning "0" in divide() is ignoring precision #57

Open
royNiladri opened this issue Mar 22, 2022 Discussed in #56 · 0 comments · May be fixed by #132
Open

Returning "0" in divide() is ignoring precision #57

royNiladri opened this issue Mar 22, 2022 Discussed in #56 · 0 comments · May be fixed by #132

Comments

@royNiladri
Copy link
Owner

Discussed in #56

Originally posted by themastermindnktp February 18, 2022
In file src/divide.ts line 17, function divide(dividend, divisor, precision), your code instantly returns "0" without processing precision. This is quite inconsistent. For example: divide("10", "2", 3) -> "5.000" while divide("0", "2", 3") -> "0".
Jsoto22 added a commit to Jsoto22/js-big-decimal that referenced this issue Apr 6, 2024
@Jsoto22
Added trailing 0s for divide by 0 with precision
78be210 
should close issue royNiladri#57
@Jsoto22 Jsoto22 linked a pull request Apr 21, 2024 that will close this issue
Draft
4 tasks
@Jsoto22 Jsoto22 linked a pull request Apr 21, 2024 that will close this issue
Development #132
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Development royNiladri/js-big-decimal
1 participant
@royNiladri