Add options to conditionally stop the recording #1896
Draft
+511
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- publish event when recording stops Signed-off-by: Nicola Loi <[email protected]>
|
Now the main computations of this PR are in sequential_writer, since it contains the data required to process the conditional stopping (eg current size, duration, message count). However I think the logic should be moved to recorder.cpp (before/after the @MichaelOrlov @fujitatomoya do you have suggestions or new ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1857.
Add
--max-recording-duration,--max-recording-size,--max-recording-messagesCLI options to conditionally stop the recording when it reaches a specified duration, size, or number of messages. The conditions consider all the possible split bags.A new event message is published when the recording stops.
This is a first working implementation trying to follow the
split_bagprocessing and event generation in sequential_writer.