Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch file migration changes #1704

Closed
rob-clarke opened this issue Jun 24, 2021 · 0 comments · Fixed by #1719
Closed

Launch file migration changes #1704

rob-clarke opened this issue Jun 24, 2021 · 0 comments · Fixed by #1719

Comments

@rob-clarke
Copy link
Contributor

I believe that the ns attribute available on the <node> element is now called namespace under ROS2. (See ros2/design#317)

This should be added as a difference from ROS1 on the launch file migration guide.
@rob-clarke rob-clarke mentioned this issue Jul 5, 2021
Merged
clalancette pushed a commit that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
fb3a919 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317
mergify bot pushed a commit that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
b116a33 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)
mergify bot pushed a commit that referenced this issue Jul 6, 2021
@rob-clarke
Update Launch-files-migration-guide.rst (#1719)
534dca5 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)
clalancette pushed a commit that referenced this issue Jul 6, 2021
@mergify @rob-clarke
Update Launch-files-migration-guide.rst (#1719) (#1724)
6e1ae94 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)

Co-authored-by: rob-clarke <[email protected]>
clalancette pushed a commit that referenced this issue Jul 6, 2021
@mergify @rob-clarke
Update Launch-files-migration-guide.rst (#1719) (#1725)
2038a7b 
Reflects change in attribute on `node` element
Fixes #1704
Ref: ros2/design#317

(cherry picked from commit fb3a919)

Co-authored-by: rob-clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Launch-files-migration-guide.rst
1 participant
@rob-clarke