Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add n_segments argument to line_segment() #558

Closed
Robinlovelace opened this issue Apr 26, 2024 · 1 comment · Fixed by #559
Closed

Re-add n_segments argument to line_segment() #558

Robinlovelace opened this issue Apr 26, 2024 · 1 comment · Fixed by #559

Comments

@Robinlovelace
Copy link
Member

As shown here the argument was lost: https://github.com/ropensci/stplanr/compare/v1.1.2..HEAD

That caused a reverse dependency fail on CRAN's auto checks:

package stplanr_1.2.0.tar.gz has been auto-processed. The auto-check found problems when checking the first order strong reverse dependencies.
Please reply-all and explain: Is this expected or do you need to fix anything in your package? If expected, have all maintainers of affected packages been informed well in advance? Are there false positives in our results?

*** Changes to worse in reverse dependencies ***
Debian: https://win-builder.r-project.org/incoming_pretest/stplanr_1.2.0_20240425_131510/reverseDependencies/summary.txt
agricolaeplotr

Log dir: https://win-builder.r-project.org/incoming_pretest/stplanr_1.2.0_20240425_131510/
The files will be removed after roughly 7 days.

Pretests:
Windows: https://win-builder.r-project.org/incoming_pretest/stplanr_1.2.0_20240425_131510/Windows/00check.log
Debian: https://win-builder.r-project.org/incoming_pretest/stplanr_1.2.0_20240425_131510/Debian/00check.log

Last published version on CRAN:

@Robinlovelace
Copy link
Member Author

Checking with

revdepcheck::revdep_check()

Robinlovelace added a commit that referenced this issue Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant