Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 7zip files take extremely long to auto extract making extracting larger archives a very long process #30

Open
wikewi opened this issue Oct 24, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@wikewi
Copy link

wikewi commented Oct 24, 2024

For some of the bigger, multi file roms/games I use 7z to store them at a higher compression and while they successfully download and do seem to start the unpacking process almost immediately after it starts unpacking it seems to halt and never finish the auto extraction job. I've tried this with a few different archives and on two computers but the results are the same. I'm not really sure if logs are maintained for this add-on if there is I'd be happy to supply more additional information.

@wikewi wikewi added the bug Something isn't working label Oct 24, 2024
@gantoine gantoine self-assigned this Nov 15, 2024
@gantoine
Copy link
Member

There should be an extensions.log file generated when errors happen, can you find it and post it here after the issue happens again? https://api.playnite.link/docs/tutorials/extensions/logging.html?tabs=csharp

@wikewi
Copy link
Author

wikewi commented Jan 14, 2025

Thanks for your reply. I have to revise my earlier statement that the extraction never finishes, because apparently it does but it's just excruciatingly slow. Also I checked the log but more interestingly there's no mention whatsoever of the extraction process. All I can find is this even after waiting almost 30 minutes for this game to extract. I can tell it did finish because eventually the button changed in playnite from installing to play, it's just that previously I didn't have the patience for it:

14-01 08:47:23.328|DEBUG|RomM#<b__0>d:Downloading Magical Drop VI to D:\romm\Magical Drop VI\Magical Drop VI.7z.
14-01 08:47:28.276|DEBUG|RomM#<b__0>d:Download of Magical Drop VI complete.

Note this is not a big game by any means around 700 mb or so zipfile that if I extract it manually it only takes 5 seconds or so (tested with both 7zip and winrar) on the same nvme drive which playnite auto extraction also takes place. However for reasons beyond my understanding the auto extract feature in playnite while it works just takes an extermely long time and as the log makes no mention of when the extraction process start or steps I'm afraid there isn't much more I can tell.

@wikewi wikewi changed the title [Bug] 7zip files do not successfully auto extract, causing installation to get stuck [Bug] 7zip files take extremely long to auto extract making extracting larger archives a very long process Jan 14, 2025
@gantoine
Copy link
Member

Closing this since the issue is slow extraction in playnite and outside the context of the plugin. I'll add some log statements in the next release to update on extraction progress.

@wikewi
Copy link
Author

wikewi commented Jan 14, 2025

Thanks for looking into this. As I'm not very technical I'm assuming the extraction is handled internally by playnite itself and I should mention this issue to the developers of playnite instead?

@gantoine
Copy link
Member

No the extraction is handled by this plugin, but we defer to the OS to extract the file. The fact that it's slow is likely an issue with the underlying OS, but I have noooooo idea how to fix that with this plugin. Not your OS specifically mind you, just the interop layer between both.

@wikewi
Copy link
Author

wikewi commented Jan 16, 2025

Ok. Just a thought but would it be possible to manually point to 7z.exe executable that can be obtained from 7zip.org and part of it's installation? It seems to be freely available and has the ability to handle most common archive types rar,zip.7z etc

@gantoine
Copy link
Member

You mean download 7z.exe as part of the install process, or make it a requirement for the romm plugin?

@wikewi
Copy link
Author

wikewi commented Jan 18, 2025

Yeah that would also be a nice option. I've seen a implementation like this on the Extra Metadata Loader plugin (for converting videos but extraction can be a fairly similar processs I guess). Unfortunately the 7zr.exe file on the 7z.org website only handles 7z files but if you install the full version the 7z.exe file installed in your program files\7zip folder should be able to handle all types of archives.

Image

@gantoine gantoine reopened this Jan 19, 2025
@gantoine
Copy link
Member

I won't be able to do this but I'll re-open the issue if someone else wants to tackle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants