Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom Platforms not able to be chosen in ROMM Integration #27

Open
Snaid1 opened this issue Sep 23, 2024 · 8 comments
Open

[Bug] Custom Platforms not able to be chosen in ROMM Integration #27

Snaid1 opened this issue Sep 23, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Snaid1
Copy link

Snaid1 commented Sep 23, 2024

Describe the bug
I cannot select custom platforms associated with emulator profiles in the ROMM Integration plugin configuration.

To Reproduce
Steps to reproduce the behavior:

  1. Add a custom platform to Playnite (Library -> Library Manager -> Platforms)
  2. Create an emulator profile that uses the newly created custom platform.
  3. Add that emulator to the ROM integration and select the new profile.
  4. the custom platform will not be available to select.

Expected behavior
when I select the profile I should be able to select the platform associated with it.

Screenshots
image
image

Additional context
I have a library in ROMM that exactly matches the platform listed in the screenshots.

@Snaid1 Snaid1 added the bug Something isn't working label Sep 23, 2024
@BloodShed-Oni
Copy link

BloodShed-Oni commented Dec 6, 2024

Experiencing similar problems.

On Romm I have a library of Vectrex games, but on Playnite the platform specification for Vectrex (from what I can see is what the plugin reads) is 'GCE Vectrex'.

When updating the library this is shown in the extension.log

|WARN |RomM#RomM:Platform GCE Vectrex with IGDB ID 67 not found in RomM, skipping.

@gantoine
Copy link
Member

gantoine commented Dec 6, 2024

Is the platform detected correctly in romm?

@BloodShed-Oni
Copy link

Is the platform detected correctly in romm?

What do you mean?

When I upload a game to Romm they are set manually to their respective platform.

I tested with DOS games and they work.

extension.log

06-12 19:44:08.552|DEBUG|RomM#RomM:Starting to fetch games for DOS.
06-12 19:44:08.852|DEBUG|RomM#RomM:Starting to parse response for DOS.
06-12 19:44:08.852|DEBUG|RomM#RomM:Finished parsing response for DOS.
06-12 19:44:08.860|DEBUG|RomM#RomM:Finished adding new games for DOS
06-12 19:44:08.860|DEBUG|RomM#RomM:Starting to remove not found games for DOS.
06-12 19:44:08.860|DEBUG|RomM#RomM:Finished removing not found games for DOS
06-12 19:44:08.911|WARN |RomM#RomM:Platform GCE Vectrex with IGDB ID 67 not found in RomM, skipping.

@gantoine
Copy link
Member

gantoine commented Dec 6, 2024

No I mean in romm, does it detect the folder as vectrex and can match games against IGDB during scan?

@BloodShed-Oni
Copy link

No I mean in romm, does it detect the folder as vectrex and can match games against IGDB during scan?

Hit & miss some are matched when uploaded, others need a manual search (I assume it's because of the filename).

But is the same with the DOS games I tested (hit & miss matching), but they get added to Playnite while Vectrex doesn't.

@gantoine gantoine self-assigned this Dec 6, 2024
@Budlyte
Copy link

Budlyte commented Jan 2, 2025

I'm having this issue with a default profile, but my platforms with custom profiles are just fine.

Working custom Switch install
image

N64 Build-in Profile
image

The N64 platform has nothing to select, and crashes Playnite if I try to delete the row.
image

Are logs generated from this crash clean and safe to upload?

@Budlyte
Copy link

Budlyte commented Jan 2, 2025

Oh, yep removing the built-in profile and using a custom profile allowed the platform selection in the library add-on.

@gantoine
Copy link
Member

gantoine commented Jan 2, 2025

Interesting find! I'm nut sure what would be causing it (as I don't know the internals of Playnite that well) but I'll leave this open for others to find/debug until I can add something to the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants