Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mp4mux sets all frame times to multiple of stream max rate, original GDCL set real frame times #30

Open
ReggThims opened this issue Sep 1, 2020 · 1 comment

Comments

@ReggThims
Copy link

Just spent the weekend thinking that I had gone mad as noticed that all timing in files was messed up. I reverted the mp4mux to the last GDCL from the original GDCL before your version of the project and the times are back to the real frame times.

I do not know at which version this happened as I do not know where to look in the source for this. It appears that you are setting the frame times to be the frame index multipled by the nominal stream frame interval... or maybe you have removed all frame times so that the only information is the frame index.

The Microsoft DirectShow doc is very unhelpful as regards frame times... the Get/SetMediaTime() functions is frame indexes, the Get/SetTime() functions are the times.

In my usage, it is vital that the correct frame times are used. The mp4demux seems to be working OK.

You can demonstrate this easily with a web cam. Set it streaming in a reduced light situation so that the frame rate falls significantly, then replay the result.

@roman380
Copy link
Owner

roman380 commented Sep 1, 2020

Are you saying that if mp4mux input has skips the produced mp4 file has incorrect times? It was quite long ago since I looked last into mp4mux but it's still working somewhere, including with variable rate webcams, and as far as I remember timings are correct there. Maybe something else is involved as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants