Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When multiple files are provided on the command line, continue past any files that cannot be parsed properly #603

Open
taladar opened this issue Dec 21, 2016 · 3 comments
Labels

Comments

@taladar
Copy link

taladar commented Dec 21, 2016

Would be useful to check the files puppet-lint can parse, especially in the presence of new, not yet supported language constructs (like the Pattern type mentioned in the other ticket I created a few minutes ago).

@rnelson0
Copy link
Collaborator

When puppet-lint returns a syntax error, that means it cannot parse the file. It would be unwise at that point to attempt linting, as the parser may not have interpreted the file correctly. See #585 for some effort to simply skip over blocks that may cause syntax errors.

@taladar
Copy link
Author

taladar commented Dec 21, 2016

I did not mean ignoring the syntax error, I meant ignoring the error for exit code purposes if multiple files are given on the command line.

@rnelson0
Copy link
Collaborator

so puppet-lint syntaxerror.pp valid.pp will process valid.pp even though the first one fails? That's something we can look at in 3.0.0 with #586, where the syntax error isn't sometimes causing a crash.

@rnelson0 rnelson0 reopened this Dec 21, 2016
@rnelson0 rnelson0 changed the title No option to ignore files with syntax errors When multiple files are provided on the command line, continue past any files that cannot be parsed properly Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants