-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup workaround in rawValues devices param parsers #991
Comments
Cleaned up the workaround with this commit: MSECode@208ad39 Ready for the PR. To clean old modified files I'll pushed just this time the generated files. |
Hi @Nicogene, |
Hi @MSECode Turn it |
Should we enable them somewhere, for example in a preset ( https://github.com/robotology/icub-main/blob/master/CMakePresets.json#L23 )? Otherwise, how can users (even internal to IIT, that will be the main target of this feature) use this interface? Other places were we may want to enable them (that I would like to substitute with preset at some point):
|
My idea was to handle this module like the Cartesian and the Gaze components, which should be OFF by default. Now, if it's a matter of exposing only the I/F in any condition we could do that but we should keep the building of the relative implementation plus the fake stuff still OFF. A shortcut could be relying on preset anyway as you suggested. |
I totally agree, that make sense, but indeed then we enable the cartesian and gaze devices everywhere else, including in the |
Yes leaving them off it is totally fine since that module should mainly have debug purposes thus it is fine that if someone needs it it will enable and use it. |
At least related to the superbuild, based on my experience I am not sure if this is a good idea. Enabling one (or several) CMake options in a subproject of the superbuild is not an intuitive (and/or fast operation) for most users, and if you are using Docker (depending on how the image is structure) it may require a long rebuild of the full image, or it simply impossible if you are using conda binaries. Documenting a long list of CMake options to enable and/or disable depending on what a user needed to do was what we did in the past (https://icub-tech-iit.github.io/documentation/sw_installation/icub_head_manual/) and it was always a source of confusion as people forgot or did errors in setting the required options. Can you at least document the options that are required to enable this functionality somewhere so that we can independently enable these options in the superbuild? |
In:
the
rawValues
debug sw pipeline has been added (interfaces, nwc, nws) to icub-main, and the devices exploit the new feature of param parsing generation of YARP.Since YARP was not released yet @MSECode added manually the header needed, but since that now YARP has been released:
This workaround can be removed, and icub-main can require
3.10.0
as yarp required version.cc @valegagge
The text was updated successfully, but these errors were encountered: