Skip to content
This repository has been archived by the owner on Jul 19, 2024. It is now read-only.

HealthCheckWrapper should have an optional param to define failureStatus #10

Open
dgaspar opened this issue Nov 21, 2021 · 0 comments
Open

HealthCheckWrapper should have an optional param to define failureStatus #10

dgaspar opened this issue Nov 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@dgaspar
Copy link

dgaspar commented Nov 21, 2021 •
edited
Loading

Notice how it's impossible to set a failureStatus:

RimDev.AspNet.Diagnostics.HealthChecks/src/RimDev.AspNet.Diagnostics.HealthChecks/RimDevAspNetHealthCheckService.cs

Line 65 in 672a4f8

null,

What business problem is this hoping to solve?

I'm trying to lower the severity of some health checks (e.g., from an UriHealthCheck, notice how it takes the failure status from the Registration: https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/50594f0643515e83f9bf6ce864f9594bf980b865/src/HealthChecks.Uris/UriHealthCheck.cs#L32)
@dgaspar dgaspar added the enhancement New feature or request label Nov 21, 2021
@dgaspar dgaspar mentioned this issue Nov 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgaspar