Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Hidden Power Type not Working for Mons not in Battle #6034

Open
iriv24 opened this issue Jan 16, 2025 · 0 comments
Open

Dynamic Hidden Power Type not Working for Mons not in Battle #6034

iriv24 opened this issue Jan 16, 2025 · 0 comments
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet

Comments

@iriv24
Copy link

iriv24 commented Jan 16, 2025

Description

The dynamic hidden power type is not showing correctly during a battle, but only when viewing the summary screen on a mon that is not currently on the field.
I know i have Rave's BW summary screen and i apologize that i was too lazy to go capture this on clean master, but i looked at the relevant code and id bet $1 the same thing will happen there.

hptype.mp4

note my omastar has hidden power flying, which shows correctly when hes the battler on the field, but does not show correctly when hes off the field.
the relevant code is in the GetDynamicMoveType function.
i changed the if (gMain.inBattle) -> if (gMain.inBattle && gBattleMons[battler].species == GetMonData(mon, MON_DATA_SPECIES)) in the case for hidden power and it resolved my issue in my own proj, but something similar may need to be done for other moves that use this function, which i havent verified yet.

Version

1.10.1 (Latest release)

Upcoming/master Version

No response

Discord contact info

iriv24

@iriv24 iriv24 added bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Development

No branches or pull requests

1 participant