Cleaner Focus Punch Handling

[Pawkkie]

Description

Focus Punch is uniquely problematic because it's a super high damage move that the AI almost never wants to go for.

#6028 refactors Focus Punch handling to be more flexible with AI scoring so the AI can actually use it, which is great, but this also means that everywhere in the codebase that calculates a maximum damage or a hits-to-KO threshold will consider Focus Punch as dealing max damage, even though it doing so is very unlikely due to the nature of Focus Punch.

I fixed the one case that was needed to pass existing tests in #6028, but there might be a smarter / cleaner solution overall given some time to think about it.

This issue is a reminder so Alex and I don't forget that we should come back to this.

Discord contact info

@Pawkkie

[i0brendan0]

Would it be a decent idea to try to give checks for scenarios that would make Focus Punch much more likely to hit?

For example

• Opponent is asleep or frozen = extreme chance of Focus Punch hitting.
• Opponent is paralyzed and/or confused = higher chance of Focus Punch hitting.
• Opponent is stuck in the recovery turn of a move like Hyper Beam and/or the opponent has Truant = certain chance of Focus Punch hitting.
• Opponent has a low accuracy stage and/or user has a high evasion = higher chance
• User knows opponent can't use a damaging move = extreme chance

The cases could go on and on, but I think these 5 count for a large number of scenarios. At least with a 1v1.

[Pawkkie]

This is actually already how Focus Punch works! :D

The issue is just that, with this approach, certain places where you don't want to consider FP's massive 150 power due to its generally poor reliability, such as places in the switching or scoring code where you need to calculate how many hits your mon can take before being KO'd, you still consider a full power FP, which leads to weird behaviour because of how unreliable it is in practice. This means that for specific handling you'd need to consider it specifically in all of these cases, which isn't super sustainable and also kind of ugly :)