Implementation of the move Protect

[ds-colo]

Description

two points of note, both in src/battle_script_commands.c:

1. in Cmd_setprotectlike, lines that increment protectUses don't bounds-check and will exceed the array length of sProtectSuccessRates on the 5th use and onwards, causing it to read incorrect values such as from sFinalStrikeOnlyEffects
2. more of a suggestion, but sProtectSuccessRates has no config for gen 6 onwards where successive uses multiply the success rate by 1/3 instead of 1/2

Attached is game and log for the array index going OOB (threshold 67 corresponds to MOVE_EFFECT_BUG_BITE value from sFinalStrikeOnlyEffects)

Version

1.10.1 (Latest release)

Upcoming/master Version

No response

Discord contact info

No response

[AlexOn1ine]

#define MAX_PROTECT_SUCCESS_RATE 4
static const u16 sProtectSuccessRates[MAX_PROTECT_SUCCESS_RATE]     = {USHRT_MAX, USHRT_MAX / 2, USHRT_MAX / 4, USHRT_MAX / 8};
static const u16 sProtectSuccessRatesGen6[MAX_PROTECT_SUCCESS_RATE] = {USHRT_MAX, USHRT_MAX / 3, USHRT_MAX / 9, USHRT_MAX / 27};

static inline u32 GetProtectSuccessRate(u32 protectUses)
{
    protectUses = (protectUses >= MAX_PROTECT_SUCCESS_RATE) ? MAX_PROTECT_SUCCESS_RATE - 1 : protectUses;
    if (B_CRITICAL_HIT_SUCCESS_RATE >= GEN_6)
        return sProtectSuccessRatesGen6[protectUses];
    return sProtectSuccessRates[protectUses];
}

Don't want to write tests right now so if anyone wants they can pick up from here. Otherwise I'll finish it sometime next week

[AlexOn1ine]

nevermind, started writing tests lol