Improve clearing the FLAG_SAFE_FOLLOWER_MOVEMENT

[Kasenn]

Description

By default, using end in a script clears the temp flag FLAG_SAFE_FOLLOWER_MOVEMENT. However, due to the way Poryscript scripts are compiled, when the end is omitted from a poryscript, it will often be substituted with a return instead, which does not clear the flag in the same way.

In order to make the script ending return clear the flag similarly to the end, this simple change should fix it:

static const u8 *ScriptPop(struct ScriptContext *ctx)
{
    if (ctx->stackDepth == 0)
+    {
+       FlagClear(FLAG_SAFE_FOLLOWER_MOVEMENT);
        return NULL;
+    }

    ctx->stackDepth--;
    return ctx->stack[ctx->stackDepth];
}

Discord contact info

No response