From 15da4e17bd885c1b1a05fcbfea8a38a96a1e434b Mon Sep 17 00:00:00 2001 From: Khaleel Al-Adhami Date: Mon, 3 Feb 2025 09:31:32 -0800 Subject: [PATCH] fix optional wrapping of static call methods in pyi (#4727) --- reflex/app.py | 2 +- reflex/components/sonner/toast.pyi | 2 +- reflex/utils/pyi_generator.py | 1 + tests/units/test_state.py | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/reflex/app.py b/reflex/app.py index 247977e7e11..060f0346969 100644 --- a/reflex/app.py +++ b/reflex/app.py @@ -151,7 +151,7 @@ def default_backend_exception_handler(exception: Exception) -> EventSpec: position="top-center", id="backend_error", style={"width": "500px"}, - ) # pyright: ignore [reportReturnType] + ) else: error_message.insert(0, "An error occurred.") return window_alert("\n".join(error_message)) diff --git a/reflex/components/sonner/toast.pyi b/reflex/components/sonner/toast.pyi index 829e959d597..632fb0d8749 100644 --- a/reflex/components/sonner/toast.pyi +++ b/reflex/components/sonner/toast.pyi @@ -177,7 +177,7 @@ class ToastNamespace(ComponentNamespace): @staticmethod def __call__( message: Union[str, Var] = "", level: Optional[str] = None, **props - ) -> "Optional[EventSpec]": + ) -> "EventSpec": """Send a toast message. Args: diff --git a/reflex/utils/pyi_generator.py b/reflex/utils/pyi_generator.py index bd9c94a6e21..beb355d31e0 100644 --- a/reflex/utils/pyi_generator.py +++ b/reflex/utils/pyi_generator.py @@ -699,6 +699,7 @@ def _generate_staticmethod_call_functiondef( value=_get_type_hint( typing.get_type_hints(clz.__call__).get("return", None), type_hint_globals, + is_optional=False, ) ), ) diff --git a/tests/units/test_state.py b/tests/units/test_state.py index 44c3f60b785..e0390c5acfa 100644 --- a/tests/units/test_state.py +++ b/tests/units/test_state.py @@ -1623,7 +1623,7 @@ def invalid_handler(self): id="backend_error", position="top-center", style={"width": "500px"}, - ) # pyright: ignore [reportCallIssue, reportArgumentType] + ) ], token="", )