Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: setup ui & setup i18n commands still use old storybook folders #11864

Closed
1 task done
Philzen opened this issue Dec 29, 2024 · 1 comment · Fixed by #11869
Closed
1 task done

[Bug]: setup ui & setup i18n commands still use old storybook folders #11864

Philzen opened this issue Dec 29, 2024 · 1 comment · Fixed by #11869
Labels
bug/needs-info More information is needed for reproduction

Comments

@Philzen
Copy link
Contributor

Philzen commented Dec 29, 2024

What's not working?

Two issues here:

  1. preview.tsx is created as web/config/storybook.preview.tsx which used to be old storybook config before Redwood 8 – in this place it won't be picked up when running yarn rw sb. Needs to be created as web/.storybook/preview.tsx instead.
  2. the web side based import path for the config file is not recognized in VS Code – but the code compiles though … so i guess this is a separate issue

grafik

grafik

When fixing issue no. 1 i'd also suggest to follow the recommendation from the chakra ui docs and create the theme file as web/src/theme/index.js instead – which will conveniently work around issue no. 2 as well 😃

How do we reproduce the bug?

yarn create redwood-app my-redwood-project
cd my-redwood-project
yarn install
yarn rw setup ui chakra-ui

Are you interested in working on this?

  • I'm interested in working on this
@Philzen Philzen added the bug/needs-info More information is needed for reproduction label Dec 29, 2024
@Philzen Philzen changed the title [Bug]: setup ui chakra-ui still uses old storybook folders [Bug]: setup ui & setup i18n commands still use old storybook folders Dec 29, 2024
@Philzen
Copy link
Contributor Author

Philzen commented Dec 29, 2024

Just checked, this also applies to setup i18n as well – the storybook file is created as web/config/storybook.preview.tsx instead of web/.storybook/preview.tsx.

Same applies to the other setup ui commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant