Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: images with captions are not well implemented #91

Closed
grandpa1946 opened this issue Apr 9, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@grandpa1946
Copy link

grandpa1946 commented Apr 9, 2024

Describe the bug

images with captions are not well implemented

Steps to reproduce the bug

view any reddit post with preview images, like this one https://www.reddit.com/r/Piracy/comments/18qt68n/guide_how_to_never_use_torrent_sites_ever_again (.json)

  1. Go to any redlib instance and visit this post
  2. Scroll down and see that every image has the same caption and is also the same
  3. See error

What's the expected behavior?

redlib implements the images in the post with captions in a better way

Additional context / screenshot

maybe this thing is causing the issue
​

@grandpa1946 grandpa1946 added the bug Something isn't working label Apr 9, 2024
@grandpa1946 grandpa1946 changed the title 🐛 Bug Report: 🐛 Bug Report: images with captions are not well implemented Apr 9, 2024
@ButteredCats
Copy link
Contributor

ButteredCats commented Apr 9, 2024

The images and captions all being the same was already fixed in #80. It's just that most instances are running the release version that doesn't include that code instead of the latest git commits which do.

However even with the latest git commits the captions wont show up because when I made the images embed I apparently overlooked that. So I just opened #92 to make sure the captions appear as well when they embed too.

@grandpa1946
Copy link
Author

The images and captions all being the same was already fixed in #80. It's just that most instances are running the release version that doesn't include that code instead of the latest git commits which do.

However even with the latest git commits the captions wont show up because when I made the images embed I apparently overlooked that. So I just opened #92 to make sure the captions appear as well when they embed too.

tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants