Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Searching in multireddit error: Could'nt send request to Reddit: Reddit response was invalid #228

Closed
azizLIGHT opened this issue Sep 15, 2024 · 3 comments · Fixed by #263
Labels
bug Something isn't working

Comments

@azizLIGHT
Copy link

Describe the bug

Trying to search stuff restricted to a multireddit gives an error
Couldn't send request to Reddit: Reddit response was invalid | /r/pics+pic/search.json?q=test&restrict_sr=on&include_over_18=on&raw_json=1

Steps to reproduce the bug

  1. Go to redlib_instance/r/pics+pic
  2. Type test in the search box at the top
  3. Make sure checkbox in the searchbox is checked for in /r/pics+pic
  4. Click arrow button or press enter
  5. See error

What's the expected behavior?

Expect to see list of posts that come from both and only /r/pics and /r/pic that match test
Multireddit here means a combo of subreddits like /r/pics+pic or /r/news+worldnews or any two or more subreddits combined with a + character

Additional context / screenshot

  • The correct results from both subreddits are available on old reddit page here
  • The results are also on old reddit json page here
  • The results are also on normal reddit json page here
@azizLIGHT azizLIGHT added the bug Something isn't working label Sep 15, 2024
@ozen-m
Copy link

ozen-m commented Sep 16, 2024

The same happens now on just normal subreddits. Even by not searching. Reddit api must have changed

Failed to parse page JSON data: expected value at line 1 column 1 | /r/popular/hot.json?&raw_json=1&geo_filter=GLOBAL

@azizLIGHT
Copy link
Author

azizLIGHT commented Sep 16, 2024

I think this error

Failed to parse page JSON data: expected value at line 1 column 1 | /r/popular/hot.json?&raw_json=1&geo_filter=GLOBAL

is new and a separate issue. This new error seems to happen on any page and just started a day ago, and only affects some instances and might be related to some blocks by reddit. So it is a more severe error than mine. That one has it's own bug report now at #229

My error about the multireddit searches was happening since at least August 18, 2024 and only happens on the multireddit search

@sigaloid
Copy link
Member

This looks like a plus-encoding issue - relevant code can be found by searching "%2B"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants