Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to js_of_ocaml #1

Open
jordwalke opened this issue Sep 21, 2016 · 1 comment
Open

Rename package to js_of_ocaml #1

jordwalke opened this issue Sep 21, 2016 · 1 comment

Comments

@jordwalke
Copy link

It's okay to keep the github repo name as is, but I think the package.json "name" field for precompiled binary packages has to match the non-precompiled version. This will make it possible to use shrinkwrap later, but even before then I believe it causes some issues.

For example, the rebel docs assume that the findlib name of a package is the same as the package.json name.

@jordwalke
Copy link
Author

Couldn't we just do what you did for rebel, where we have the same package but with a git tag #bin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant