Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ubuntu Radiance Theme #7

Open
m31317015 opened this issue Oct 29, 2017 · 10 comments
Open

[Feature Request] Ubuntu Radiance Theme #7

m31317015 opened this issue Oct 29, 2017 · 10 comments

Comments

@m31317015
Copy link

Just curious if you are going to port it.

I'd love to use the theme if you're making it happening. <3

@SolarLiner
Copy link
Collaborator

I could work on it despite me absolutely hating the theme 🤣

School is preventing me from maintaining the current themes, much less make yet another one (I still have to finish the Flat Pat one!). If you're experienced enough with making themes, I would totally accept a PR with an initial version of the theme if you were to make one. But I won't promise I'll have a working theme in a close future.

I'm leaving this open though.

@m31317015
Copy link
Author

Same situation goes for me, I'm working on school projects like C++ timetable app and Simple Vulkan objects. I'd like to give a PR but I'm not experienced in json, maybe I would try to take some time to make it in a week or two.

Thanks for responding anyway. I'll send you mine if I have chance finishing it, or I'll reply here even if I can't. :)

@SolarLiner
Copy link
Collaborator

image
Here's a first draft for it based on the Ambiance theme. What do you think?

@m31317015
Copy link
Author

m31317015 commented Nov 5, 2017

Maybe a lil brighter on the folder contents, and maybe change the grey to the purple terminals are using?

And I got no time making one xD, Thanks.
Edit: Maybe this as another theme? The theme I want is Radiance but this is not too close from it. It looks nice tho so maybe keep it?

@SolarLiner SolarLiner self-assigned this Nov 9, 2017
@SolarLiner SolarLiner added this to the v1.1 milestone Nov 9, 2017
@m31317015
Copy link
Author

Since this is added to Todo list, I'll just close this issue. Thanks for the theme. 😄

@SolarLiner
Copy link
Collaborator

SolarLiner commented Dec 1, 2017

Reopening this for progress tracking reasons.

@SolarLiner SolarLiner reopened this Dec 1, 2017
@SolarLiner SolarLiner changed the title Ubuntu Radiance Theme Port? [Feature Request] Ubuntu Radiance Theme Dec 1, 2017
@m31317015
Copy link
Author

Okay. Thanks. Also is there a ETA of 1.1? I'm looking forward to using it. 😄

@SolarLiner
Copy link
Collaborator

I'll have time to work on it inbetween Christmas and New Year, hopefully. Not sure if that'll be enough to release a new version, though...

@rdnlsmith rdnlsmith modified the milestones: v1.1, v1.3 Nov 16, 2019
@rdnlsmith rdnlsmith modified the milestones: v1.3, v1.4 Jul 19, 2020
@Feichtmeier
Copy link
Contributor

Speaking of light headerbars in light themes... could you also add a Yaru-light theme? :)

Bildschirmfoto von 2020-08-05 10-51-59

@rdnlsmith
Copy link
Owner

@Feichtmeier are there any differences between Yaru (Standard) and Yaru Light besides the titlebar?

I imagine that most people who are interested in Linux-themed VSCode would use the native titlebars, in which case the existing Yaru theme instantly becomes Yaru Light (unless there are other differences). But, if there are people using the custom titlebars, I suppose I would be willing to duplicate the Yaru theme but with light titlebars. Or alternatively, I could just make the one Yaru theme have light custom titlebars—what are your thoughts on that?

@m31317015 are you still interested in a Radiance theme after 3 years, or have you moved on?

I've debated whether it still makes sense to add/improve the Ambiance/Radiance themes now that Yaru is the default in an LTS. Feedback welcome from anyone reading this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants