Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve countValuesWhereOpConditions method in DataCategory #37

Open
brindakv opened this issue Jan 8, 2025 · 0 comments
Open

Improve countValuesWhereOpConditions method in DataCategory #37

brindakv opened this issue Jan 8, 2025 · 0 comments

Comments

@brindakv
Copy link
Collaborator

brindakv commented Jan 8, 2025

Improve countValuesWhereOpConditions method (and other methods if relevant) in DataCategory by adding a break when conditions are False in order to increase efficiency.

See comment and discussion below:
I'm noticing now that you have this break here whereas the other methods don't (e.g., countValuesWhereOpConditions). Should we add this to those other ones too? Seems like a logical efficiency to me, versus wasting time iterating over things once it's False.

Originally posted by @piehld in #36 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant