You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve countValuesWhereOpConditions method (and other methods if relevant) in DataCategory by adding a break when conditions are False in order to increase efficiency.
See comment and discussion below:
I'm noticing now that you have this break here whereas the other methods don't (e.g., countValuesWhereOpConditions). Should we add this to those other ones too? Seems like a logical efficiency to me, versus wasting time iterating over things once it's False.
Improve
countValuesWhereOpConditions
method (and other methods if relevant) inDataCategory
by adding a break when conditions areFalse
in order to increase efficiency.See comment and discussion below:
I'm noticing now that you have this
break
here whereas the other methods don't (e.g.,countValuesWhereOpConditions
). Should we add this to those other ones too? Seems like a logical efficiency to me, versus wasting time iterating over things once it'sFalse
.Originally posted by @piehld in #36 (comment)
The text was updated successfully, but these errors were encountered: