From d631f40085f663489fe686f5edcacf6e0b3c86e9 Mon Sep 17 00:00:00 2001 From: hjiang Date: Thu, 12 Dec 2024 21:43:09 +0000 Subject: [PATCH 1/3] remove grpc client thread number Signed-off-by: hjiang --- src/ray/rpc/grpc_client.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ray/rpc/grpc_client.h b/src/ray/rpc/grpc_client.h index d86475fbdf6b..ed9ff1ab742c 100644 --- a/src/ray/rpc/grpc_client.h +++ b/src/ray/rpc/grpc_client.h @@ -116,9 +116,6 @@ class GrpcClient { bool use_tls = false) : client_call_manager_(call_manager), use_tls_(use_tls) { grpc::ChannelArguments argument = CreateDefaultChannelArguments(); - grpc::ResourceQuota quota; - quota.SetMaxThreads(num_threads); - argument.SetResourceQuota(quota); argument.SetInt(GRPC_ARG_ENABLE_HTTP_PROXY, ::RayConfig::instance().grpc_enable_http_proxy() ? 1 : 0); argument.SetMaxSendMessageSize(::RayConfig::instance().max_grpc_message_size()); From 4ad71da5d96454be59511d3da34ee8c8ce87e456 Mon Sep 17 00:00:00 2001 From: hjiang Date: Thu, 12 Dec 2024 23:47:22 +0000 Subject: [PATCH 2/3] remove grpc client constructor Signed-off-by: hjiang --- src/ray/rpc/grpc_client.h | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/ray/rpc/grpc_client.h b/src/ray/rpc/grpc_client.h index ed9ff1ab742c..e07abe243e22 100644 --- a/src/ray/rpc/grpc_client.h +++ b/src/ray/rpc/grpc_client.h @@ -109,22 +109,6 @@ class GrpcClient { stub_ = GrpcService::NewStub(channel_); } - GrpcClient(const std::string &address, - const int port, - ClientCallManager &call_manager, - int num_threads, - bool use_tls = false) - : client_call_manager_(call_manager), use_tls_(use_tls) { - grpc::ChannelArguments argument = CreateDefaultChannelArguments(); - argument.SetInt(GRPC_ARG_ENABLE_HTTP_PROXY, - ::RayConfig::instance().grpc_enable_http_proxy() ? 1 : 0); - argument.SetMaxSendMessageSize(::RayConfig::instance().max_grpc_message_size()); - argument.SetMaxReceiveMessageSize(::RayConfig::instance().max_grpc_message_size()); - - channel_ = BuildChannel(address, port, argument); - stub_ = GrpcService::NewStub(channel_); - } - /// Create a new `ClientCall` and send request. /// /// \tparam Request Type of the request message. From c080c61232ff3be71d5b8ddb449ab6fd52045030 Mon Sep 17 00:00:00 2001 From: hjiang Date: Fri, 13 Dec 2024 21:59:33 +0000 Subject: [PATCH 3/3] remove callsite Signed-off-by: hjiang --- src/ray/rpc/object_manager/object_manager_client.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ray/rpc/object_manager/object_manager_client.h b/src/ray/rpc/object_manager/object_manager_client.h index 1185558a1702..19a8e4264e5b 100644 --- a/src/ray/rpc/object_manager/object_manager_client.h +++ b/src/ray/rpc/object_manager/object_manager_client.h @@ -48,8 +48,8 @@ class ObjectManagerClient { freeobjects_rr_index_ = rand() % num_connections_; grpc_clients_.reserve(num_connections_); for (int i = 0; i < num_connections_; i++) { - grpc_clients_.emplace_back(new GrpcClient( - address, port, client_call_manager, num_connections_)); + grpc_clients_.emplace_back( + new GrpcClient(address, port, client_call_manager)); } };