From 518171ec8cbd2440d431876b31cea327077e2082 Mon Sep 17 00:00:00 2001 From: kaihsun Date: Sat, 23 Nov 2024 05:50:19 +0000 Subject: [PATCH 1/2] update Signed-off-by: kaihsun --- python/ray/scripts/scripts.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/python/ray/scripts/scripts.py b/python/ray/scripts/scripts.py index 1f26a483a7aa..ee82322103e8 100644 --- a/python/ray/scripts/scripts.py +++ b/python/ray/scripts/scripts.py @@ -622,6 +622,13 @@ def debug(address: str, verbose: bool): type=str, help="a JSON serialized dictionary mapping label name to label value.", ) +@click.option( + "--include-log-monitor", + default=None, + type=bool, + help="If set to True or left unset, a log monitor will start to monitor " + "the log files of all processes on this node and push their contents to GCS.", +) @add_click_logging_options @PublicAPI def start( @@ -668,6 +675,7 @@ def start( ray_debugger_external, disable_usage_stats, labels, + include_log_monitor, ): """Start Ray processes manually on the local machine.""" @@ -757,6 +765,7 @@ def start( no_monitor=no_monitor, tracing_startup_hook=tracing_startup_hook, ray_debugger_external=ray_debugger_external, + include_log_monitor=include_log_monitor, ) if ray_constants.RAY_START_HOOK in os.environ: From d4adeaa35ae2c68c034e09d3904c1f8cce8c91ba Mon Sep 17 00:00:00 2001 From: kaihsun Date: Mon, 25 Nov 2024 19:37:13 +0000 Subject: [PATCH 2/2] update Signed-off-by: kaihsun --- python/ray/scripts/scripts.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/ray/scripts/scripts.py b/python/ray/scripts/scripts.py index ee82322103e8..eed702bb7438 100644 --- a/python/ray/scripts/scripts.py +++ b/python/ray/scripts/scripts.py @@ -626,8 +626,10 @@ def debug(address: str, verbose: bool): "--include-log-monitor", default=None, type=bool, - help="If set to True or left unset, a log monitor will start to monitor " - "the log files of all processes on this node and push their contents to GCS.", + help="If set to True or left unset, a log monitor will start monitoring " + "the log files of all processes on this node and push their contents to GCS. " + "Only one log monitor should be started per physical host to avoid log " + "duplication on the driver process.", ) @add_click_logging_options @PublicAPI