Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserAgent triggering false new device notifications #40

Open
sunscreem opened this issue Jan 26, 2022 · 6 comments
Open

UserAgent triggering false new device notifications #40

sunscreem opened this issue Jan 26, 2022 · 6 comments

Comments

@sunscreem
Copy link

This packages works great, just I'm experiencing a few "false" new device notifications.

My question is should a user get a notification if they have updated their browser?

Take these two UserAgent strings:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.1 Safari/605.1.15

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Safari/605.1.15

I'd suggest the version should be ignored?

@lucasjose501
Copy link

I noticed that behavior too, I think the only other way is using cookies and we know that lately this could create some issues with cookie laws. Same thing for dynamic IP address.

@alekbless
Copy link

Agreed, a lot of NewDevice Notifications is being created by this behavior. Configurable ignoring browser version may help.

@justbadproger
Copy link

Author does not answer issue for a long time, I also do not observe activity in repository last time. Can I consider this package seriously for new application or mb better choose something else?

@xavicabot
Copy link

Same problem, a lot of log notifications with this

The script tried to call a method on an incomplete object. Please ensure that the class definition "Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice" of the object you are trying to operate on was loaded before unserialize() gets called or provide an autoloader to load the class definition {"exception":"[object] (Error(code: 0): The script tried to call a method on an incomplete object. Please ensure that the class definition "Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice" of the object you are trying to operate on was loaded before unserialize() gets called or provide an autoloader to load the class definition at /home/forge/app.unancor.com/vendor/laravel/framework/src/Illuminate/Notifications/SendQueuedNotifications.php:125)

Any suggests?

@emadabuselmiya
Copy link

Same problem, a lot of log notifications with this
TypeError
Rappasoft\LaravelAuthenticationLog\Notifications\NewDevice::__construct(): Argument #1 ($authenticationLog) must be of type Rappasoft\LaravelAuthenticationLog\Models\AuthenticationLog, Yadahan\AuthenticationLog\AuthenticationLog given, called in E:\smart trade\website-smart-trade\vendor\rappasoft\laravel-authentication-log\src\Listeners\LoginListener.php on line 43

I used muti Gurad auth

Any suggests?

@mit-0044
Copy link

mit-0044 commented Jul 7, 2023

mail is not sending when i login from new device of failed to login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants